Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: WithdrawalRequestNFT #560

Merged
merged 24 commits into from
Feb 7, 2023
Merged

Feat: WithdrawalRequestNFT #560

merged 24 commits into from
Feb 7, 2023

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Feb 6, 2023 •
edited by folkyatina
Loading

  • Full-fledged IERC721 implementation
  • claimWithdrawal is now permissioned-only, but with _recipient parameter.

TheDZhon
TheDZhon requested changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mind-blowing to add a full-fleged NFT implementation 💎

Left some suggestions

contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalNFT.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueueBase.sol Outdated Show resolved Hide resolved
@folkyatina folkyatina changed the title Feat: WithdrawalNFT Feat: WithdrawalRequestNFT Feb 6, 2023
@folkyatina folkyatina marked this pull request as ready for review February 6, 2023 22:04
@TheDZhon TheDZhon merged commit 15fff06 into feature/shapella-upgrade Feb 7, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-withdrawal-nft branch February 7, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon Awaiting requested review from TheDZhon

@ujenjt ujenjt Awaiting requested review from ujenjt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Psirex @TheDZhon @folkyatina